feat: enable paste for empty array fields#924
Merged
Conversation
stevenle
changed the title
stevenle
changed the title
Member
Author
|
@jeremydw this is ready for review, the main goal of this is to add a way to "paste" when there are no array items (currently you have to add a blank one, paste, and then remove the empty item) 
|
Member
|
It's a bit awkward but I can't think of a better UI for this without a bigger refactor (like having an "empty items" list). Let's submit for now and refactor later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
DocEditor.ArrayFieldso the primaryAddbutton remains and a dropdown menu sits beside it inpackages/root-cms/ui/components/DocEditor/DocEditor.tsx.Pastemenu item that invokespasteFromVirtualClipboard(order.length - 1)so paste works even when the array is empty..DocEditor__ArrayField__add__actionsinpackages/root-cms/ui/components/DocEditor/DocEditor.cssto layout the add button and dropdown inline with spacing.Testing
pnpm -C packages/root-cms build:ui, which failed due to the environment being unable to downloadpnpm(Corepack network/proxy 403), so the package build could not be validated here.ERR_EMPTY_RESPONSEbecause no web app was available at the target port in this environment.Codex Task